[Doc] Make the background section concise and improve its formality#18928
[Doc] Make the background section concise and improve its formality#18928wla80 wants to merge 1 commit intonodejs:masterfrom
Conversation
mmarchini
left a comment
mmarchini
left a comment
There was a problem hiding this comment.
Thanks for the contribution! I left a couple of comments, but other than that LGTM
doc/guides/maintaining-V8.md
Outdated
There was a problem hiding this comment.
I think we can change a version with versions or multiple versions since we support one version of V8 for each release line.
There was a problem hiding this comment.
Thanks for pointing out. I will revise it:)
doc/guides/maintaining-V8.md
Outdated
There was a problem hiding this comment.
Could you be so kind and wrap this paragraph at 80 characters?
There was a problem hiding this comment.
Could you specify how can I achieve this without losing information. Also, I think this paragraph can be removed since the sections discussed in the paragraph were already explicitly stated in the document.
There was a problem hiding this comment.
Sorry, I meant wrap every line in the paragraph at 80 characters. Otherwise, our linter will complain :)
This document attempts to outline the current maintaining processes, proposes
a workflow for maintaining the V8 branches in both Node.js LTS and current
releases, and discusses how the Node.js and V8 teams at Google can help.There was a problem hiding this comment.
Sure, I will fix this. Sorry for the confusion and thank you again.
claudiorodriguez
left a comment
claudiorodriguez
left a comment
There was a problem hiding this comment.
LGTM, just a tiny nit: commit message doesn't fit the guidelines
doc/guides/maintaining-V8.md
Outdated
There was a problem hiding this comment.
Nit: maintenance processes seems more natural to me than maintaining processes
|
Hello @claudiorodriguez, I just uploaded a new commit to address the incorrect commit message format. Please let me know if I am still doing it wrong. thanks |
mmarchini
added
the
author ready
|
Landed in a27e6d7, thanks! 😄 |
PR-URL: #18928 Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: nodejs#18928 Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: nodejs#18928 Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: nodejs#18928 Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
7 participants
Improve the writing quality of the background section in maintaining-V8.md